Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2255)

Issue 1234823002: PartitionAlloc: Add a lock to Partitions::initialize() (Closed)

Created:
5 years, 5 months ago by haraken
Modified:
5 years, 5 months ago
Reviewers:
tkent, Chris Evans, bashi
CC:
blink-reviews, Mads Ager (chromium), oilpan-reviews, blink-reviews-wtf_chromium.org, kouhei+heap_chromium.org, Mikhail
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

PartitionAlloc: Add a lock to Partitions::initialize() It is possible that multiple threads contend with initializing Partitions. We need to acquire a lock before doing the initialization. BUG=508700 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198825

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M Source/wtf/Partitions.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/wtf/Partitions.cpp View 1 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
haraken
PTAL. It seems my previous comment (https://codereview.chromium.org/1190883003/#msg5) was wrong.
5 years, 5 months ago (2015-07-13 00:51:43 UTC) #2
bashi
non-owner LGTM
5 years, 5 months ago (2015-07-13 23:27:10 UTC) #3
haraken
+tkent-san: Mind taking a look as an owner?
5 years, 5 months ago (2015-07-13 23:32:08 UTC) #5
tkent
https://codereview.chromium.org/1234823002/diff/1/Source/wtf/Partitions.h File Source/wtf/Partitions.h (right): https://codereview.chromium.org/1234823002/diff/1/Source/wtf/Partitions.h#newcode102 Source/wtf/Partitions.h:102: static int s_lock; let's give more descriptive name. e.g. ...
5 years, 5 months ago (2015-07-14 00:42:36 UTC) #6
haraken
On 2015/07/14 00:42:36, tkent wrote: > https://codereview.chromium.org/1234823002/diff/1/Source/wtf/Partitions.h > File Source/wtf/Partitions.h (right): > > https://codereview.chromium.org/1234823002/diff/1/Source/wtf/Partitions.h#newcode102 > ...
5 years, 5 months ago (2015-07-14 00:51:25 UTC) #7
tkent
lgtm
5 years, 5 months ago (2015-07-14 01:08:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234823002/20001
5 years, 5 months ago (2015-07-14 01:08:22 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 02:11:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198825

Powered by Google App Engine
This is Rietveld 408576698