Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: content/browser/fileapi/blob_url_request_job_unittest.cc

Issue 1234813004: [BlobAsync] Asynchronous Blob Construction Final Patch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blob-protocol-change
Patch Set: comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/fileapi/blob_url_request_job_unittest.cc
diff --git a/content/browser/fileapi/blob_url_request_job_unittest.cc b/content/browser/fileapi/blob_url_request_job_unittest.cc
index 96becf0de0935ae062abb6c67546b526fc088cd6..bd03422d8002dfac1d5dc5122b567a4d91d6992c 100644
--- a/content/browser/fileapi/blob_url_request_job_unittest.cc
+++ b/content/browser/fileapi/blob_url_request_job_unittest.cc
@@ -37,8 +37,9 @@
#include "storage/browser/fileapi/file_system_url.h"
#include "testing/gtest/include/gtest/gtest.h"
-using storage::BlobDataSnapshot;
using storage::BlobDataBuilder;
+using storage::BlobDataHandle;
+using storage::BlobDataSnapshot;
using storage::BlobURLRequestJob;
namespace content {
@@ -108,7 +109,7 @@ class BlobURLRequestJobTest : public testing::Test {
class MockProtocolHandler :
public net::URLRequestJobFactory::ProtocolHandler {
public:
- MockProtocolHandler(BlobURLRequestJobTest* test) : test_(test) {}
+ explicit MockProtocolHandler(BlobURLRequestJobTest* test) : test_(test) {}
// net::URLRequestJobFactory::ProtocolHandler override.
net::URLRequestJob* MaybeCreateJob(
@@ -283,7 +284,7 @@ class BlobURLRequestJobTest : public testing::Test {
*expected_result += std::string(kTestFileSystemFileData2 + 6, 7);
}
- storage::BlobDataHandle* GetHandleFromBuilder() {
+ BlobDataHandle* GetHandleFromBuilder() {
if (!blob_handle_) {
blob_handle_ = blob_context_.AddFinishedBlob(blob_data_.get()).Pass();
}
@@ -324,7 +325,7 @@ class BlobURLRequestJobTest : public testing::Test {
scoped_refptr<storage::FileSystemContext> file_system_context_;
storage::BlobStorageContext blob_context_;
- scoped_ptr<storage::BlobDataHandle> blob_handle_;
+ scoped_ptr<BlobDataHandle> blob_handle_;
scoped_ptr<BlobDataBuilder> blob_data_;
scoped_ptr<BlobDataSnapshot> blob_data_snapshot_;
net::URLRequestJobFactoryImpl url_request_job_factory_;

Powered by Google App Engine
This is Rietveld 408576698