[BlobAsync] Asynchronous Blob Construction Final Patch

storage/common/blob_storage/blob_storage_constants.h

Index: storage/common/blob_storage/blob_storage_constants.h
diff --git a/storage/common/blob_storage/blob_storage_constants.h b/storage/common/blob_storage/blob_storage_constants.h
index e77c8683527875b420adb80fd0b87b357b276dce..ad96b483a365616ab5d4eafffed50b5bbb7dac3b 100644
--- a/storage/common/blob_storage/blob_storage_constants.h
+++ b/storage/common/blob_storage/blob_storage_constants.h
@@ -28,11 +28,23 @@ enum class IPCBlobItemRequestStrategy {
   LAST = FILE
 };
 
+// These items cannot be reordered or renumbered. New items must be added

[Mark P, 2016/03/16 19:25:50]

Please mention the reason: these enum values are recorded to UMA.

[dmurph, 2016/03/30 20:13:26]

Done.

+// immediately before LAST, and LAST must be set to the the last item.
 enum class IPCBlobCreationCancelCode {
   UNKNOWN = 0,
-  OUT_OF_MEMORY,
-  FILE_WRITE_FAILED,
-  LAST = FILE_WRITE_FAILED
+  OUT_OF_MEMORY = 1,
+  FILE_WRITE_FAILED = 2,
+  // The renderer was destroyed while data was in transit.
+  SOURCE_DIED_IN_TRANSIT = 3,
+  // The renderer destructed the blob before it was done transferring, and there
+  // were no outstanding references (no one is waiting to read) to keep the
+  // blob alive.
+  BLOB_DEREFERENCED_WHILE_BUILDING = 4,
+  // A blob that we we referenced during construction is broken, or a browser-

[Mark P, 2016/03/16 19:25:50]

nit: "we we" -> "we"

[dmurph, 2016/03/30 20:13:26]

Done.

+  // side builder tries to build a blob with a blob reference that isn't
+  // finished constructing.
+  REFERENCED_BLOB_BROKEN = 5,
+  LAST = REFERENCED_BLOB_BROKEN
 };
 
 }  // namespace storage