Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 1234813003: Revert of Implement DOM: prepend, append, before, after & replaceWith (Closed)

Created:
5 years, 5 months ago by dominicc (has gone to gerrit)
Modified:
5 years, 5 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Implement DOM: prepend, append, before, after & replaceWith (patchset #23 id:500001 of https://codereview.chromium.org/1085843002/) Reason for revert: I suspect that this caused Issue 509461. Original issue's description: > Implement DOM: prepend, append, before, after & replaceWith > > As per https://dom.spec.whatwg.org/#childnode ChildNode interface > should contain before(), after() and replaceWith() API. > > As per https://dom.spec.whatwg.org/#parentnode ParentNode interface > should contain prepend(), append() API. > > Intent to Implement and ship link: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/paritosh/blink-dev/efUPtYm1PP8/MGoTi17AYpcJ > > BUG=255482 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198629 TBR=haraken@chromium.org,tkent@chromium.org,philipj@opera.com,paritosh.in@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=255482 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198750

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -789 lines) Patch
D LayoutTests/fast/dom/ChildNode/after.html View 1 chunk +0 lines, -135 lines 0 comments Download
D LayoutTests/fast/dom/ChildNode/before.html View 1 chunk +0 lines, -135 lines 0 comments Download
D LayoutTests/fast/dom/ChildNode/replace-with.html View 1 chunk +0 lines, -120 lines 0 comments Download
D LayoutTests/fast/dom/ParentNode/append.html View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/fast/dom/ParentNode/append-on-document.html View 1 chunk +0 lines, -50 lines 0 comments Download
D LayoutTests/fast/dom/ParentNode/prepend.html View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/fast/dom/ParentNode/prepend-on-document.html View 1 chunk +0 lines, -50 lines 0 comments Download
M LayoutTests/webexposed/element-instance-property-listing-expected.txt View 6 chunks +0 lines, -10 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 6 chunks +0 lines, -15 lines 0 comments Download
M Source/core/dom/ChildNode.h View 1 chunk +0 lines, -15 lines 0 comments Download
M Source/core/dom/ChildNode.idl View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/core/dom/Node.h View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +0 lines, -90 lines 0 comments Download
M Source/core/dom/ParentNode.h View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/dom/ParentNode.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
dominicc (has gone to gerrit)
Created Revert of Implement DOM: prepend, append, before, after & replaceWith
5 years, 5 months ago (2015-07-13 05:38:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234813003/1
5 years, 5 months ago (2015-07-13 05:38:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=198750
5 years, 5 months ago (2015-07-13 05:39:07 UTC) #3
philipj_slow
https://code.google.com/p/chromium/issues/detail?id=509461 is 403, can you CC me?
5 years, 5 months ago (2015-07-13 07:15:25 UTC) #4
haraken
5 years, 5 months ago (2015-07-13 07:21:47 UTC) #5
Message was sent while issue was closed.
On 2015/07/13 07:15:25, philipj wrote:
> https://code.google.com/p/chromium/issues/detail?id=509461 is 403, can you CC
> me?

CCed.

Powered by Google App Engine
This is Rietveld 408576698