Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1234803004: Update big_red_button instructions and add --dry-run mode. (Closed)

Created:
5 years, 5 months ago by eseidel
Modified:
5 years, 5 months ago
Reviewers:
Cutch
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Update big_red_button instructions and add --dry-run mode. I also made the add_argument blocks shorter by allowing more than one named arg per line. I removed the metavar lines and action=store lines since one was only used in help messages and the other was already matching the default for add_argument. R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/f8fce3f3b6a1b5cf9c9a8b8174cbbfb4bfcd8d18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -41 lines) Patch
M sky/tools/big_red_button.py View 4 chunks +34 lines, -41 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
5 years, 5 months ago (2015-07-13 22:21:50 UTC) #1
Cutch
lgtm
5 years, 5 months ago (2015-07-13 22:24:45 UTC) #2
eseidel
5 years, 5 months ago (2015-07-13 22:24:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f8fce3f3b6a1b5cf9c9a8b8174cbbfb4bfcd8d18 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698