Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1234783005: Add API to send NSUserDefault values over IPC, while preserving current behavior (Closed)

Created:
5 years, 5 months ago by Greg K
Modified:
5 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, dglazkov+blink, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add API to send NSUserDefault values over IPC, while preserving current behavior This adds the API to allow the renderer to receive the NSUserDefault values over IPC. This will be necessary once the Bootstrap sandbox is enabled, as the renderer process will not be able to access NSUserdefaults directly. However, until the change in the main browser code lands, this CL is careful to preserve the existing behavior. BUG=392141 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199177

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -31 lines) Patch
M Source/platform/mac/ScrollAnimatorMac.mm View 1 chunk +4 lines, -18 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacCommon.h View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacCommon.mm View 3 chunks +9 lines, -2 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacNonOverlayAPI.mm View 1 chunk +5 lines, -7 lines 0 comments Download
M Source/web/mac/WebScrollbarTheme.mm View 1 chunk +25 lines, -1 line 0 comments Download
M public/web/mac/WebScrollbarTheme.h View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Greg K
5 years, 5 months ago (2015-07-17 23:06:09 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-20 08:17:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234783005/1
5 years, 5 months ago (2015-07-20 16:49:50 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 18:10:17 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199177

Powered by Google App Engine
This is Rietveld 408576698