pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart - Issue 1234753003: dart2js cps: Rewrite mutable variables to continuation parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart

Issue 1234753003: dart2js cps: Rewrite mutable variables to continuation parameters. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Add tests and fix an assertion Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart

diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart

index 47d7898cb424814daa5392b8210ce23f11e55774..90456e9c4193559aec08a6d646af1ca4d23c63ca 100644

--- a/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart

+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart

@@ -612,7 +612,7 @@ class Builder implements cps_ir.Visitor<Node> {

node.dependency);

return continueWithExpression(node.continuation, foreignCode);

} else {

- assert(node.continuation == null);

+ assert(node.continuation.definition.body is cps_ir.Unreachable);

return new ForeignStatement(

node.codeTemplate,

node.type,