Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: mojo/edk/system/endpoint_relayer.cc

Issue 1234683002: Convert some more |base::Lock|s to |mojo::system::Mutex|s. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/endpoint_relayer.h ('k') | mojo/edk/system/incoming_endpoint.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/endpoint_relayer.cc
diff --git a/mojo/edk/system/endpoint_relayer.cc b/mojo/edk/system/endpoint_relayer.cc
index 96302163d6e90d83b8a347a8796c703f948b40fb..c672b6e17e2674ae5df64cfc294bf9c4af7d213d 100644
--- a/mojo/edk/system/endpoint_relayer.cc
+++ b/mojo/edk/system/endpoint_relayer.cc
@@ -21,7 +21,8 @@ unsigned EndpointRelayer::GetPeerPort(unsigned port) {
}
void EndpointRelayer::Init(ChannelEndpoint* endpoint0,
- ChannelEndpoint* endpoint1) {
+ ChannelEndpoint* endpoint1)
+ MOJO_NO_THREAD_SAFETY_ANALYSIS {
kulakowski 2015/07/10 21:53:47 I wonder if this pattern (having to make |Init| fu
DCHECK(endpoint0);
DCHECK(endpoint1);
DCHECK(!endpoints_[0]);
@@ -31,14 +32,14 @@ void EndpointRelayer::Init(ChannelEndpoint* endpoint0,
}
void EndpointRelayer::SetFilter(scoped_ptr<Filter> filter) {
- base::AutoLock locker(lock_);
+ MutexLocker locker(&mutex_);
filter_ = filter.Pass();
}
bool EndpointRelayer::OnReadMessage(unsigned port, MessageInTransit* message) {
DCHECK(message);
- base::AutoLock locker(lock_);
+ MutexLocker locker(&mutex_);
// If we're no longer the client, then reject the message.
if (!endpoints_[port])
@@ -59,7 +60,7 @@ bool EndpointRelayer::OnReadMessage(unsigned port, MessageInTransit* message) {
}
void EndpointRelayer::OnDetachFromChannel(unsigned port) {
- base::AutoLock locker(lock_);
+ MutexLocker locker(&mutex_);
if (endpoints_[port]) {
endpoints_[port]->DetachFromClient();
« no previous file with comments | « mojo/edk/system/endpoint_relayer.h ('k') | mojo/edk/system/incoming_endpoint.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698