Issue 1234673002: Clean up error returns for unsupported pthread mutex/cond attr values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1234673002: Clean up error returns for unsupported pthread mutex/cond attr values (Closed)

Created:
5 years, 5 months ago by Roland McGrath

Modified:
5 years, 5 months ago

Reviewers:
Petr Hosek, Sam Clegg

CC:
native-client-reviews_googlegroups.com, Mark Seaborn

Base URL:
https://chromium.googlesource.com/native_client/nacl-glibc.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Clean up error returns for unsupported pthread mutex/cond attr values NaCl does not support process-shared pthread mutexes or cond variables. glibc's libpthread functions should report proper errors for that. Likewise NaCl does not support pthread_condattr_setclock for any clock value other than CLOCK_REALTIME, but the proper error code for CLOCK_MONOTONIC is ENOTSUP rather than EINVAL (because CLOCK_MONOTONIC is a "known clock" for other purposes, just not supported for this one). Returning ENOTSUP for these cases is consistent with what the new (upstream) glibc does. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4142 TEST= toolchain trybots R=phosek@chromium.org, sbc@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-glibc.git;a=commit;h=11835d88570805fc9db4436a4299efd3b1b1e825

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -56 lines)			Patch
M	nptl/pthread_condattr_setclock.c	View	1 chunk	+14 lines, -37 lines	0 comments	Download
M	nptl/pthread_condattr_setpshared.c	View	1 chunk	+10 lines, -7 lines	0 comments	Download
M	nptl/pthread_mutexattr_setpshared.c	View	1 chunk	+9 lines, -12 lines	0 comments	Download

Total messages: 3 (0 generated)

Roland McGrath

5 years, 5 months ago (2015-07-10 22:03:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
11835d88570805fc9db4436a4299efd3b1b1e825 (presubmit successful).