Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: content/browser/manifest/manifest_manager_host.cc

Issue 1234653004: webapps: utilize manifest theme colors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix missing include Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/shortcut_info.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/manifest/manifest_manager_host.cc
diff --git a/content/browser/manifest/manifest_manager_host.cc b/content/browser/manifest/manifest_manager_host.cc
index a978f70295b859da87c36cf55f8bba2703228256..492cd49a2868a415ae8c9d55dd201f057e577485 100644
--- a/content/browser/manifest/manifest_manager_host.cc
+++ b/content/browser/manifest/manifest_manager_host.cc
@@ -139,7 +139,8 @@ void ManifestManagerHost::OnRequestManifestResponse(
// theme_color is a 32 bit unsigned integer with a 64 bit integer simply
// being used to encode an error occuring. Therefore, any value outside the
// range of an unsigned 32 bit integer is invalid.
- if (manifest.theme_color < 0 || manifest.theme_color > 0xFFFFFFFF)
+ if (manifest.theme_color < std::numeric_limits<int32_t>::min() ||
+ manifest.theme_color > std::numeric_limits<int32_t>::max())
manifest.theme_color = Manifest::kInvalidOrMissingThemeColor;
callback->Run(manifest);
« no previous file with comments | « chrome/browser/android/shortcut_info.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698