webapps: utilize manifest theme colors

chrome/browser/android/shortcut_info.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/shortcut_info.h"
 
 ShortcutInfo::ShortcutInfo()
     : display(content::Manifest::DISPLAY_MODE_BROWSER),
       orientation(blink::WebScreenOrientationLockDefault),
+      theme_color(content::Manifest::kInvalidOrMissingThemeColor),
       source(SOURCE_ADD_TO_HOMESCREEN) {
 }
 
 ShortcutInfo::ShortcutInfo(const GURL& shortcut_url)
     : url(shortcut_url),
       display(content::Manifest::DISPLAY_MODE_BROWSER),
       orientation(blink::WebScreenOrientationLockDefault),
+      theme_color(content::Manifest::kInvalidOrMissingThemeColor),

[mlamouri (slow - plz ping), 2015/07/20 13:29:45]

I think you can try to use a C++11 new feature: delegated constructor. I'm not
100% if it does work for default ctor but I don't see an obvious reason why it
shouldn't. Could you try:

ShortcutInfo::ShortcutInfo(const GURL& shortcut_url)
    : ShorcutInfo(),
      url(shortcut_url) {
  [...]
}

That way, you don't need to repeat yourself.

[Lalit Maganti, 2015/07/20 13:56:13]

Done.

[Bernhard Bauer, 2015/07/20 17:11:35]

Is it?

[Lalit Maganti, 2015/07/20 17:17:04]

I did try it but since Android uses GCC and not Clang, initializer lists are not
allowed :(

[Bernhard Bauer, 2015/08/11 09:40:47]

:(

OTOH, the style guide actually does allow default arguments in constructors
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Default_Argum...),
so you could use that.

       source(SOURCE_ADD_TO_HOMESCREEN) {
 }
 
 void ShortcutInfo::UpdateFromManifest(const content::Manifest& manifest) {
   if (!manifest.short_name.is_null())
     title = manifest.short_name.string();
   else if (!manifest.name.is_null())
     title = manifest.name.string();
 
   // Set the url based on the manifest value, if any.
@@ skipping 12 matching lines @@
     display = content::Manifest::DISPLAY_MODE_BROWSER;
 
   // Set the orientation based on the manifest value, if any.
   if (manifest.orientation != blink::WebScreenOrientationLockDefault) {
     // Ignore the orientation if the display mode is different from
     // 'standalone'.
     // TODO(mlamouri): send a message to the developer console about this.
     if (display == content::Manifest::DISPLAY_MODE_STANDALONE)
       orientation = manifest.orientation;
   }
+
+  // Set the theme color based on the manifest value, if any

[mlamouri (slow - plz ping), 2015/07/20 13:29:45]

nit: finish the sentence with a period.

[Lalit Maganti, 2015/07/20 13:56:13]

Done.

+  if (manifest.theme_color != content::Manifest::kInvalidOrMissingThemeColor)
+    theme_color = manifest.theme_color;
 }
 
 void ShortcutInfo::UpdateSource(const Source new_source) {
   source = new_source;
 }