Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1234643002: customtabs: Convert to the new AIDL interface, temporarily imported. (Closed)

Created:
5 years, 5 months ago by Yusuf
Modified:
5 years, 5 months ago
Reviewers:
pasko, Ian Wen, Benoit L, Maria
CC:
chromium-reviews, ianwen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

customtabs: Convert to the new AIDL interface, temporarily imported. - Update the service implementation and the matching tests for Custom Tabs to the current external AIDL interfaces - Temporarily import the files in Chrome - Remove the chromium AIDL files - Update GYP and GN files TESTED=unittests and example application TBR=mariakhomenko@chromium.org Committed: https://crrev.com/e143ef3aec7bb1abe74b564a0f0c859e6e7f8b58 Cr-Commit-Position: refs/heads/master@{#338360}

Patch Set 1 #

Patch Set 2 : Added VisibleForTesting to util only used for testing #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+426 lines, -426 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/android/chrome_apk.gyp View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/android/java/AndroidManifest.xml View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/proguard.flags View 1 chunk +9 lines, -1 line 0 comments Download
A chrome/android/java/src/android/support/customtabs/CustomTabsIntent.java View 1 chunk +75 lines, -0 lines 1 comment Download
A chrome/android/java/src/android/support/customtabs/ICustomTabsCallback.aidl View 1 chunk +17 lines, -0 lines 0 comments Download
A chrome/android/java/src/android/support/customtabs/ICustomTabsService.aidl View 1 chunk +21 lines, -0 lines 0 comments Download
A + chrome/android/java/src/android/support/customtabs/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/android/java/src/android/support/customtabs/common.aidl View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java View 6 chunks +11 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 9 chunks +14 lines, -15 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabContentHandler.java View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java View 4 chunks +38 lines, -106 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java View 15 chunks +98 lines, -122 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/customtabs/ICustomTabsConnectionCallback.aidl View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/customtabs/ICustomTabsConnectionService.aidl View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/customtabs/common.aidl View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/IntentUtils.java View 1 2 chunks +62 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java View 6 chunks +48 lines, -48 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Yusuf
reupload of https://codereview.chromium.org/1224553003/ with me as the owner because there was a one line import ...
5 years, 5 months ago (2015-07-10 19:36:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234643002/20001
5 years, 5 months ago (2015-07-10 21:01:36 UTC) #4
Ian Wen
https://codereview.chromium.org/1234643002/diff/20001/chrome/android/java/src/android/support/customtabs/CustomTabsIntent.java File chrome/android/java/src/android/support/customtabs/CustomTabsIntent.java (right): https://codereview.chromium.org/1234643002/diff/20001/chrome/android/java/src/android/support/customtabs/CustomTabsIntent.java#newcode74 chrome/android/java/src/android/support/customtabs/CustomTabsIntent.java:74: "android.support.customtabs.extra.EXIT_ANIMATION_BUNDLE"; This file did not include EXTRA_CUSTOM_TABS_TITLE_VISIBILITY_STATE, right? So ...
5 years, 5 months ago (2015-07-10 21:12:35 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-10 21:22:24 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e143ef3aec7bb1abe74b564a0f0c859e6e7f8b58 Cr-Commit-Position: refs/heads/master@{#338360}
5 years, 5 months ago (2015-07-10 21:23:26 UTC) #8
Benoit L
5 years, 5 months ago (2015-07-15 08:03:33 UTC) #9
Message was sent while issue was closed. 
On 2015/07/10 21:23:26, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/e143ef3aec7bb1abe74b564a0f0c859e6e7f8b58
> Cr-Commit-Position: refs/heads/master@{#338360}

lgtm

Powered by Google App Engine
This is Rietveld 408576698