Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 123463005: GN Command line -D parsing, goma on Windows (Closed)

Created:
6 years, 11 months ago by brettw
Modified:
6 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

GN Command line -D parsing, goma on Windows This makes gyp_chromium pass defines defined via -D on the command line to GN. Fixes double-escaping of strings from supplemental.gypi files. Pass use_goma to the GN build. Handle "use_goma" and "use_goma=1" (same for other boolean values). Previously values with no equals sign were getting converted to 'true', which doesn't match '1' which we look for. Output goma wrappers in the GYP header for Windows toolchains. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243446

Patch Set 1 #

Patch Set 2 : Don't use optparse #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -15 lines) Patch
M build/gyp_chromium View 1 5 chunks +34 lines, -15 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
6 years, 11 months ago (2014-01-06 22:05:16 UTC) #1
scottmg
lgtm
6 years, 11 months ago (2014-01-06 22:10:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/123463005/110001
6 years, 11 months ago (2014-01-07 00:57:18 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) app_list_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 11 months ago (2014-01-07 11:01:45 UTC) #4
brettw
Committed patchset #2 manually as r243446 (presubmit successful).
6 years, 11 months ago (2014-01-08 00:32:22 UTC) #5
Nico
6 years, 11 months ago (2014-01-08 19:21:24 UTC) #6
Message was sent while issue was closed.
This broke building on OS X and is blocking me from work
(http://crbug.com/332458). Unless there's an easy, quick fix this should
probably be reverted for now.

Powered by Google App Engine
This is Rietveld 408576698