Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 123463004: Don't allow software fallback for UI compositor on CrOS (Closed)

Created:
6 years, 11 months ago by ccameron
Modified:
6 years, 11 months ago
Reviewers:
danakj
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

Don't allow software fallback for UI compositor on CrOS BUG=331847 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243250

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporate review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/browser/aura/gpu_process_transport_factory.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ccameron
This look reasonable?
6 years, 11 months ago (2014-01-06 19:20:10 UTC) #1
danakj
https://codereview.chromium.org/123463004/diff/1/ui/compositor/compositor.cc File ui/compositor/compositor.cc (right): https://codereview.chromium.org/123463004/diff/1/ui/compositor/compositor.cc#newcode518 ui/compositor/compositor.cc:518: #if defined(OS_CHROMEOS) Can we keep the #ifdefs out of ...
6 years, 11 months ago (2014-01-06 19:33:06 UTC) #2
ccameron
https://codereview.chromium.org/123463004/diff/1/ui/compositor/compositor.cc File ui/compositor/compositor.cc (right): https://codereview.chromium.org/123463004/diff/1/ui/compositor/compositor.cc#newcode518 ui/compositor/compositor.cc:518: #if defined(OS_CHROMEOS) On 2014/01/06 19:33:06, danakj wrote: > Can ...
6 years, 11 months ago (2014-01-06 19:47:02 UTC) #3
danakj
Ifdefs suck for unit testing, but I think we can deal with this later. LGTM
6 years, 11 months ago (2014-01-06 20:32:12 UTC) #4
ccameron
It's true... Thanks!!
6 years, 11 months ago (2014-01-06 21:25:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/123463004/60001
6 years, 11 months ago (2014-01-06 21:27:36 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 10:58:12 UTC) #7
Message was sent while issue was closed. 
Change committed as 243250

Powered by Google App Engine
This is Rietveld 408576698