Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: LayoutTests/fast/forms/listbox-onchange.html

Issue 1234613004: Only execute default actions on trusted events. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master_event_trusted_main3
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/forms/listbox-onchange.html
diff --git a/LayoutTests/fast/forms/listbox-onchange.html b/LayoutTests/fast/forms/listbox-onchange.html
index ccb3d05884b805808fec2056e93e8e2e42bd98ed..ccd6129e9df105656b3da63cc1bd8815fe74ca40 100644
--- a/LayoutTests/fast/forms/listbox-onchange.html
+++ b/LayoutTests/fast/forms/listbox-onchange.html
@@ -122,34 +122,44 @@
function mouseDownOnSelect(selId, index, shift, metaOrCtrl)
{
- var meta = false;
- var ctrl = false;
+ modifiers = [];
+ if (shift)
+ modifiers[0] = "shiftKey";
tkent 2015/07/22 23:15:03 modifiers.push("shiftKey")
dtapuska 2015/07/23 01:28:10 Done.
if (metaOrCtrl) {
if (navigator.userAgent.search(/\bMac OS X\b/) != -1)
tkent 2015/07/22 23:15:03 We can simplify this block by modifiers.push("
dtapuska 2015/07/23 01:28:10 Done.
- meta = true;
+ modifiers[modifiers.length] = "metaKey";
tkent 2015/07/22 23:15:03 modifiers.push("metaKey")
dtapuska 2015/07/23 01:28:10 Done.
else
- ctrl = true;
+ modifiers[modifiers.length] = "ctrlKey";
tkent 2015/07/22 23:15:03 modifiers.push("ctrlKey")
dtapuska 2015/07/23 01:28:10 Done.
}
var sl = document.getElementById(selId);
- var event = document.createEvent("MouseEvent");
- event.initMouseEvent("mousedown", true, true, document.defaultView, 1, 0, 0, 0, 0, ctrl, false, shift, meta, 0, document);
- sl.options[index].dispatchEvent(event);
+ var rect = sl.options[index].getBoundingClientRect();
+ if (window.eventSender) {
+ eventSender.mouseMoveTo(rect.left + 1, rect.top + 1);
+ eventSender.mouseDown(0, modifiers);
+ } else {
+ debug("FAIL: This test requires window.eventSender.");
tkent 2015/07/22 23:15:03 should be testFaiiled("This test requires wind
dtapuska 2015/07/23 01:28:10 Done.
+ }
}
function mouseUpOnSelect(selId, index, shift, metaOrCtrl)
{
- var meta = false;
- var ctrl = false;
+ modifiers = [];
+ if (shift)
+ modifiers[0] = "shiftKey";
tkent 2015/07/22 23:15:03 modifiers.push("shiftKey")
dtapuska 2015/07/23 01:28:10 Done.
if (metaOrCtrl) {
if (navigator.userAgent.search(/\bMac OS X\b/) != -1)
tkent 2015/07/22 23:15:03 modifiers.push("addSelectionKey");
dtapuska 2015/07/23 01:28:10 Done.
- meta = true;
+ modifiers[modifiers.length] = "metaKey";
else
- ctrl = true;
+ modifiers[modifiers.length] = "ctrlKey";
}
var sl = document.getElementById(selId);
- var event = document.createEvent("MouseEvent");
- event.initMouseEvent("mouseup", true, true, document.defaultView, 1, 0, 0, 0, 0, ctrl, false, shift, meta, 0, document);
- sl.options[index].dispatchEvent(event);
+ var rect = sl.options[index].getBoundingClientRect();
+ if (window.eventSender) {
+ eventSender.mouseMoveTo(rect.left + 1, rect.top + 1);
+ eventSender.mouseUp(0, modifiers);
+ } else {
+ debug("FAIL: This test requires window.eventSender.");
tkent 2015/07/22 23:15:03 testFailed("This test ...");
dtapuska 2015/07/23 01:28:10 Done.
+ }
}
function keyDownOnSelect(selId, identifier, shift, metaOrCtrl)
@@ -161,7 +171,7 @@
if (navigator.userAgent.search(/\bMac OS X\b/) != -1)
tkent 2015/07/22 23:15:03 modifiers.push("addSelectionKey");
dtapuska 2015/07/23 01:28:10 Done.
modifiers[modifiers.length] = "metaKey";
else
- modifiers[modifiers.length] = "controlKey";
+ modifiers[modifiers.length] = "ctrlKey";
}
document.getElementById(selId).focus();

Powered by Google App Engine
This is Rietveld 408576698