public/platform/modules/presentation/WebPresentationClient.h - Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/modules/presentation/WebPresentationClient.h

Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: retry! Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « public/platform/modules/notifications/WebNotificationManager.h ('k') | public/platform/modules/push_messaging/WebPushProvider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: public/platform/modules/presentation/WebPresentationClient.h

diff --git a/public/platform/modules/presentation/WebPresentationClient.h b/public/platform/modules/presentation/WebPresentationClient.h

index 9ea599016138dcc6d869d47cd2688039a6e97cab..e8f8a48b5125c0caa8e6821ea2a342f6a8fe0b34 100644

--- a/public/platform/modules/presentation/WebPresentationClient.h

+++ b/public/platform/modules/presentation/WebPresentationClient.h

@@ -7,6 +7,7 @@

#include "public/platform/WebCallbacks.h"

#include "public/platform/WebCommon.h"

+#include "public/platform/WebPassOwnPtr.h"

namespace blink {

@@ -19,10 +20,10 @@ struct WebPresentationError;

// If session was created, callback's onSuccess() is invoked with the information about the

// presentation session created by the embedder. Otherwise, onError() is invoked with the error code

// and message.

-using WebPresentationSessionClientCallbacks = WebCallbacks<WebPresentationSessionClient*, WebPresentationError*>;

+using WebPresentationSessionClientCallbacks = WebCallbacks<WebPassOwnPtr<WebPresentationSessionClient>, WebPassOwnPtr<WebPresentationError>>;

// Callback for .getAvailability().

-using WebPresentationAvailabilityCallbacks = WebCallbacks<bool*, WebPresentationError*>;

+using WebPresentationAvailabilityCallbacks = WebCallbacks<WebPassOwnPtr<bool>, WebPassOwnPtr<WebPresentationError>>;

// The implementation the embedder has to provide for the Presentation API to work.

class WebPresentationClient {