Source/modules/serviceworkers/ServiceWorkerWindowClient.h - Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerWindowClient.h

Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: retry! Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerError.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerWindowClient.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerWindowClient.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerWindowClient.h b/Source/modules/serviceworkers/ServiceWorkerWindowClient.h

index 399144742dab4bc85a5aefa8ecb22993890e197a..c0c714f2f173574ecfb76eb8f8435e6c909f9bd2 100644

--- a/Source/modules/serviceworkers/ServiceWorkerWindowClient.h

+++ b/Source/modules/serviceworkers/ServiceWorkerWindowClient.h

@@ -10,6 +10,7 @@

#include "modules/serviceworkers/ServiceWorkerClient.h"

#include "platform/heap/Handle.h"

#include "wtf/Forward.h"

+#include "wtf/OwnPtr.h"

#include "wtf/PassOwnPtr.h"

namespace blink {

@@ -21,9 +22,9 @@ class MODULES_EXPORT ServiceWorkerWindowClient final : public ServiceWorkerClien

DEFINE_WRAPPERTYPEINFO();

public:

// To be used by CallbackPromiseAdapter.

- typedef WebServiceWorkerClientInfo WebType;

+ using WebType = OwnPtr<WebServiceWorkerClientInfo>;

- static ServiceWorkerWindowClient* take(ScriptPromiseResolver*, PassOwnPtr<WebType>);

+ static ServiceWorkerWindowClient* take(ScriptPromiseResolver*, PassOwnPtr<WebServiceWorkerClientInfo>);

static ServiceWorkerWindowClient* create(const WebServiceWorkerClientInfo&);

~ServiceWorkerWindowClient() override;