Source/modules/presentation/PresentationAvailability.h - Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/presentation/PresentationAvailability.h

Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: retry! Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp ('k') | Source/modules/presentation/PresentationAvailability.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/presentation/PresentationAvailability.h

diff --git a/Source/modules/presentation/PresentationAvailability.h b/Source/modules/presentation/PresentationAvailability.h

index 4489679bb098aecf8f4c4ae631bf99bcf74c4522..c05294f1c6ef33b5cd570dd1f4209b676f7e0c41 100644

--- a/Source/modules/presentation/PresentationAvailability.h

+++ b/Source/modules/presentation/PresentationAvailability.h

@@ -29,9 +29,9 @@ class PresentationAvailability final

DEFINE_WRAPPERTYPEINFO();

public:

// For CallbackPromiseAdapter.

- using WebType = bool;

+ using WebType = OwnPtr<bool>;

- static PresentationAvailability* take(ScriptPromiseResolver*, bool);

+ static PresentationAvailability* take(ScriptPromiseResolver*, PassOwnPtr<bool>);

~PresentationAvailability() override;

// EventTarget implementation.