public/platform/modules/notifications/WebNotificationManager.h - Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/modules/notifications/WebNotificationManager.h

Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/CallbackPromiseAdapter.h ('K') | « public/platform/modules/bluetooth/WebBluetooth.h ('k') | public/platform/modules/push_messaging/WebPushProvider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: public/platform/modules/notifications/WebNotificationManager.h

diff --git a/public/platform/modules/notifications/WebNotificationManager.h b/public/platform/modules/notifications/WebNotificationManager.h

index a4697a2d133a5704d60f978819357758bf4e85a2..af580a5c356343d0c2c2eb4fa92ab346a343f609 100644

--- a/public/platform/modules/notifications/WebNotificationManager.h

+++ b/public/platform/modules/notifications/WebNotificationManager.h

@@ -6,6 +6,7 @@

#define WebNotificationManager_h

#include "public/platform/WebCallbacks.h"

+#include "public/platform/WebPrivateOwnPtr.h"

#include "public/platform/WebString.h"

#include "public/platform/WebVector.h"

#include "public/platform/modules/notifications/WebNotificationData.h"

@@ -24,7 +25,7 @@ struct WebPersistentNotificationInfo {

WebNotificationData data;

};

-using WebNotificationGetCallbacks = WebCallbacks<WebVector<WebPersistentNotificationInfo>*, void>;

+using WebNotificationGetCallbacks = WebCallbacks<WebPrivateOwnPtr<WebVector<WebPersistentNotificationInfo>>&&, void>;

using WebNotificationShowCallbacks = WebCallbacks<void, void>;

// Provides the services to show platform notifications to the user.