Source/modules/cachestorage/InspectorCacheStorageAgent.cpp - Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/CallbackPromiseAdapter.h ('K') | « Source/modules/cachestorage/CacheStorageError.cpp ('k') | Source/modules/geofencing/Geofencing.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

diff --git a/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp b/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

index f9ed2ba4e3882067bb61613770a84a24cfabcc7f..ec19f4bc5f00d6f083029b06a37fc82ca1bce8fa 100644

--- a/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

+++ b/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

@@ -346,9 +346,10 @@ public:

m_callback->sendSuccess();

}

- void onError(WebServiceWorkerCacheError* error)

+ void onError(WebPrivateOwnPtr<WebServiceWorkerCacheError>&& e)

{

- m_callback->sendFailure(String::format("Error requesting cache names: %s", serviceWorkerCacheErrorString(error).data()));

+ OwnPtr<WebServiceWorkerCacheError> error = e.release();

+ m_callback->sendFailure(String::format("Error requesting cache names: %s", serviceWorkerCacheErrorString(error.get()).data()));

}

private: