Source/modules/cachestorage/Cache.cpp - Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/cachestorage/Cache.cpp

Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/CallbackPromiseAdapter.h ('K') | « Source/modules/bluetooth/ConvertWebVectorToArrayBuffer.h ('k') | Source/modules/cachestorage/CacheStorageError.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/cachestorage/Cache.cpp

diff --git a/Source/modules/cachestorage/Cache.cpp b/Source/modules/cachestorage/Cache.cpp

index fff953336d27cb52a1f951a42b60fdd9ad655cf1..2c0991f47de4bad7e11512b5a46c785d315f8a3e 100644

--- a/Source/modules/cachestorage/Cache.cpp

+++ b/Source/modules/cachestorage/Cache.cpp

@@ -95,10 +95,9 @@ public:

m_resolver.clear();

}

- // Ownership of |rawReason| must be passed.

- void onError(WebServiceWorkerCacheError* rawReason) override

+ void onError(WebPrivateOwnPtr<WebServiceWorkerCacheError>&& rawReason) override

{

- OwnPtr<WebServiceWorkerCacheError> reason = adoptPtr(rawReason);

+ OwnPtr<WebServiceWorkerCacheError> reason = rawReason.release();

if (*reason == WebServiceWorkerCacheErrorNotFound)

m_resolver->resolve(false);

else