public/platform/modules/push_messaging/WebPushProvider.h - Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/modules/push_messaging/WebPushProvider.h

Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/platform/modules/push_messaging/WebPushProvider.h

diff --git a/public/platform/modules/push_messaging/WebPushProvider.h b/public/platform/modules/push_messaging/WebPushProvider.h

index 188d0db4958ccee256bbc15bbb64f428959b28f1..e18726aca34b4fd8d8c41ca0a101c6afc412d407 100644

--- a/public/platform/modules/push_messaging/WebPushProvider.h

+++ b/public/platform/modules/push_messaging/WebPushProvider.h

@@ -17,7 +17,7 @@ struct WebPushSubscriptionOptions;

using WebPushSubscriptionCallbacks = WebCallbacks<WebPushSubscription*, WebPushError*>;

using WebPushPermissionStatusCallbacks = WebCallbacks<WebPushPermissionStatus*, WebPushError*>;

-using WebPushUnsubscribeCallbacks = WebCallbacks<bool*, WebPushError*>;

+using WebPushUnsubscribeCallbacks = WebCallbacks<bool*, WebPassOwnPtr<WebPushError>>;

class WebPushProvider {

public:

« public/platform/modules/bluetooth/WebBluetooth.h ('K') | « public/platform/modules/presentation/WebPresentationClient.h ('k') | no next file » | no next file with comments »