public/platform/WebServiceWorkerCache.h - Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/platform/WebServiceWorkerCache.h

Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/CallbackPromiseAdapter.h ('K') | « public/platform/WebGeofencingProvider.h ('k') | public/platform/WebServiceWorkerClientsClaimCallbacks.h » ('j') | public/platform/modules/bluetooth/WebBluetooth.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: public/platform/WebServiceWorkerCache.h

diff --git a/public/platform/WebServiceWorkerCache.h b/public/platform/WebServiceWorkerCache.h

index 1d8a0c6e2cf23001af8cba1120afdc99406d353a..85f75e8a25533e449e6d6b20701a7c50cdda5511 100644

--- a/public/platform/WebServiceWorkerCache.h

+++ b/public/platform/WebServiceWorkerCache.h

@@ -7,6 +7,7 @@

#include "public/platform/WebCallbacks.h"

#include "public/platform/WebCommon.h"

+#include "public/platform/WebPassOwnPtr.h"

#include "public/platform/WebServiceWorkerCacheError.h"

#include "public/platform/WebServiceWorkerRequest.h"

#include "public/platform/WebServiceWorkerResponse.h"

@@ -23,7 +24,7 @@ public:

using CacheMatchCallbacks = WebCallbacks<WebServiceWorkerResponse*, WebServiceWorkerCacheError*>;

using CacheWithResponsesCallbacks = WebCallbacks<WebVector<WebServiceWorkerResponse>*, WebServiceWorkerCacheError*>;

using CacheWithRequestsCallbacks = WebCallbacks<WebVector<WebServiceWorkerRequest>*, WebServiceWorkerCacheError*>;

- using CacheBatchCallbacks = WebCallbacks<void, WebServiceWorkerCacheError*>;

+ using CacheBatchCallbacks = WebCallbacks<void, WebPassOwnPtr<WebServiceWorkerCacheError>>;

virtual ~WebServiceWorkerCache() { }