Source/modules/cachestorage/CacheStorageError.h - Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/cachestorage/CacheStorageError.h

Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/CallbackPromiseAdapter.h ('K') | « Source/modules/cachestorage/Cache.cpp ('k') | Source/modules/cachestorage/CacheStorageError.cpp » ('j') | public/platform/modules/bluetooth/WebBluetooth.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/cachestorage/CacheStorageError.h

diff --git a/Source/modules/cachestorage/CacheStorageError.h b/Source/modules/cachestorage/CacheStorageError.h

index f28b21634ec530304dc47cf22d3f36823668af3b..505b8ae2285b5d5a2a1acca673afb9a158ecc763 100644

--- a/Source/modules/cachestorage/CacheStorageError.h

+++ b/Source/modules/cachestorage/CacheStorageError.h

@@ -7,6 +7,7 @@

#include "public/platform/WebServiceWorkerCacheError.h"

#include "wtf/Noncopyable.h"

+#include "wtf/OwnPtr.h"

#include "wtf/PassOwnPtr.h"

namespace blink {

@@ -19,10 +20,10 @@ class CacheStorageError {

public:

// For CallbackPromiseAdapter. Ownership of a given error is not

// transferred.

- using WebType = WebServiceWorkerCacheError;

- static DOMException* take(ScriptPromiseResolver*, PassOwnPtr<WebType> webError);

+ using WebType = OwnPtr<WebServiceWorkerCacheError>;

+ static DOMException* take(ScriptPromiseResolver*, PassOwnPtr<WebServiceWorkerCacheError> webError);

- static DOMException* createException(WebType webError);

+ static DOMException* createException(WebServiceWorkerCacheError webError);

};

} // namespace blink