Source/modules/bluetooth/BluetoothGATTService.h - Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/bluetooth/BluetoothGATTService.h

Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/CallbackPromiseAdapter.h ('K') | « Source/modules/bluetooth/BluetoothGATTRemoteServer.h ('k') | Source/modules/bluetooth/ConvertWebVectorToArrayBuffer.h » ('j') | public/platform/modules/bluetooth/WebBluetooth.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/bluetooth/BluetoothGATTService.h

diff --git a/Source/modules/bluetooth/BluetoothGATTService.h b/Source/modules/bluetooth/BluetoothGATTService.h

index 0c00daa19dbeb2fd513f04e4ed86d4af8dfb7dbb..f547dc8e58919bc60148735b1d698cdf38d0cb3e 100644

--- a/Source/modules/bluetooth/BluetoothGATTService.h

+++ b/Source/modules/bluetooth/BluetoothGATTService.h

@@ -9,6 +9,7 @@

#include "bindings/modules/v8/UnionTypesModules.h"

#include "platform/heap/Handle.h"

#include "public/platform/modules/bluetooth/WebBluetoothGATTService.h"

+#include "wtf/OwnPtr.h"

#include "wtf/PassOwnPtr.h"

#include "wtf/text/WTFString.h"

@@ -34,7 +35,7 @@ public:

explicit BluetoothGATTService(PassOwnPtr<WebBluetoothGATTService>);

// Interface required by CallbackPromiseAdapter:

- typedef WebBluetoothGATTService WebType;

+ using WebType = OwnPtr<WebBluetoothGATTService>;

static BluetoothGATTService* take(ScriptPromiseResolver*, PassOwnPtr<WebBluetoothGATTService>);

// Interface required by garbage collection.