Issue 12346002: overscroll: Fix an issue where the overscroll window could get stuck.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12346002: overscroll: Fix an issue where the overscroll window could get stuck. (Closed)

Created:
7 years, 10 months ago by sadrul

Modified:
7 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

overscroll: Fix an issue where the overscroll window could get stuck. While the content page is still loading after a gesture navigation, the overlay that shows the preview of the history page should not forward input events to the content page. Forwarding events during this time can get the overscroll controller into an inconsistent state (because the overscroll controller does not receive the whole stream of events after the overlay window is destroyed). BUG=174186 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184660

Patch Set 1 #

Patch Set 2 : fix-tests #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -6 lines)			Patch
M	content/browser/web_contents/web_contents_view_aura.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/web_contents/web_contents_view_aura.cc	View	1	11 chunks	+36 lines, -6 lines	0 comments	Download
M	content/browser/web_contents/web_contents_view_aura_browsertest.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

7 years, 10 months ago (2013-02-26 16:16:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r184660 (presubmit successful).

Expand Messages | Collapse Messages