Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1234593002: Changed omnibox rendering to use a single asset. (Closed)

Created:
5 years, 5 months ago by bruthig
Modified:
5 years, 5 months ago
Reviewers:
Peter Kasting, oshima
CC:
chromium-reviews, oshima+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed omnibox rendering to use a single asset. Depends on https://codereview.chromium.org/1224233003/ . BUG=501355 Committed: https://crrev.com/f2dbbabc6860c82632c264e5dfed608a4c12b5f7 Cr-Commit-Position: refs/heads/master@{#338443}

Patch Set 1 #

Patch Set 2 : Fixed baseline. #

Total comments: 2

Patch Set 3 : Moved LocationBarView::CreateBorderPainter() method inline. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M chrome/app/theme/theme_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 1 chunk +11 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
bruthig
oshima@chromium.org: Please review changes in - theme_resources.grd pkasting@chromium.org: Please review changes in - location_bar_view.(h|cc)
5 years, 5 months ago (2015-07-10 15:06:53 UTC) #2
Peter Kasting
lgtm https://codereview.chromium.org/1234593002/diff/20001/chrome/browser/ui/views/location_bar/location_bar_view.cc File chrome/browser/ui/views/location_bar/location_bar_view.cc (right): https://codereview.chromium.org/1234593002/diff/20001/chrome/browser/ui/views/location_bar/location_bar_view.cc#newcode181 chrome/browser/ui/views/location_bar/location_bar_view.cc:181: CreateBorderPainter(); Just leave your new code inlined here ...
5 years, 5 months ago (2015-07-10 15:57:09 UTC) #3
oshima
c/a/theme lgtm
5 years, 5 months ago (2015-07-10 16:24:40 UTC) #4
bruthig
https://codereview.chromium.org/1234593002/diff/20001/chrome/browser/ui/views/location_bar/location_bar_view.cc File chrome/browser/ui/views/location_bar/location_bar_view.cc (right): https://codereview.chromium.org/1234593002/diff/20001/chrome/browser/ui/views/location_bar/location_bar_view.cc#newcode181 chrome/browser/ui/views/location_bar/location_bar_view.cc:181: CreateBorderPainter(); On 2015/07/10 15:57:09, Peter Kasting wrote: > Just ...
5 years, 5 months ago (2015-07-10 17:04:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234593002/40001
5 years, 5 months ago (2015-07-11 13:40:32 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-11 14:16:01 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-11 14:17:59 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f2dbbabc6860c82632c264e5dfed608a4c12b5f7
Cr-Commit-Position: refs/heads/master@{#338443}

Powered by Google App Engine
This is Rietveld 408576698