Issue 1234573005: Revert of Trace MessageLoop::RunTask execution

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1234573005: Revert of Trace MessageLoop::RunTask execution (Closed)

Created:
5 years, 5 months ago by caseq

Modified:
5 years, 5 months ago

Reviewers:
danakj, dsinclair, nduca

CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Trace MessageLoop::RunTask execution (patchset #2 id:20001 of https://codereview.chromium.org/1225333002/) Reason for revert: Regressed perf on Nexus 7 BUG=509982, 508005 Original issue's description: > Trace MessageLoop::RunTask execution > > Previously, we were only issuing trace events around the task execution > within TaskAnnotator::RunTask. However, this does not include time spent > in observers (see bug for details on how it bites). > > BUG=508005 > > Committed: https://crrev.com/87a2c639ff073ed3194a788ee1eaf82aabe77bab > Cr-Commit-Position: refs/heads/master@{#338492} TBR=danakj@chromium.org,dsinclair@chromium.org,nduca@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=508005 Committed: https://crrev.com/2f52af4946455e3872c5e949f5fe6f4e50103da8 Cr-Commit-Position: refs/heads/master@{#338676}

Created: 5 years, 5 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	base/message_loop/message_loop.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234573005/1

5 years, 5 months ago (2015-07-14 13:30:29 UTC) #2

commit-bot: I haz the power

5 years, 5 months ago (2015-07-14 13:32:38 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2f52af4946455e3872c5e949f5fe6f4e50103da8
Cr-Commit-Position: refs/heads/master@{#338676}