Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 1234573004: Remove old createMediaPlayer method from WebFrameClient implementations (Closed)

Created:
5 years, 5 months ago by Srirama
Modified:
5 years, 5 months ago
Reviewers:
philipj_slow, jam, ddorwin
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove old createMediaPlayer method from WebFrameClient implementations Now that the blink has shifted to new createMediaPlayer method, removing the old method from all the WebFrameClient implementations. This will allow blink to separate the WebMediaPlayerEncryptedMediaClient from WebMediaPlayerClient and remove the MediaPlayer and MediaPlayerClient interfaces which is the ultimate goal of the mentioned bugs. BUG=350571, 310466 Committed: https://crrev.com/9d1423af551de300783135062156069539dc57e0 Cr-Commit-Position: refs/heads/master@{#338825}

Patch Set 1 #

Total comments: 6

Patch Set 2 : removed redundant include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -45 lines) Patch
M components/html_viewer/frame.h View 1 chunk +0 lines, -6 lines 0 comments Download
M components/html_viewer/frame.cc View 1 2 chunks +0 lines, -9 lines 0 comments Download
M components/html_viewer/html_document.h View 1 chunk +0 lines, -6 lines 0 comments Download
M components/html_viewer/html_document.cc View 1 2 chunks +0 lines, -9 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
Srirama
PTAL. This is the last intermediate CL and i can goto https://codereview.chromium.org/1055503002/ after this.
5 years, 5 months ago (2015-07-14 14:40:56 UTC) #2
philipj_slow
Neither ddorwin nor I are owners of these files, but non-owner LGTM.
5 years, 5 months ago (2015-07-14 14:49:54 UTC) #3
Srirama
On 2015/07/14 14:49:54, philipj wrote: > Neither ddorwin nor I are owners of these files, ...
5 years, 5 months ago (2015-07-14 15:08:28 UTC) #4
ddorwin
LGTM % removal of includes added in https://codereview.chromium.org/1133033003/. https://codereview.chromium.org/1234573004/diff/1/components/html_viewer/frame.cc File components/html_viewer/frame.cc (right): https://codereview.chromium.org/1234573004/diff/1/components/html_viewer/frame.cc#newcode36 components/html_viewer/frame.cc:36: #include ...
5 years, 5 months ago (2015-07-14 18:25:10 UTC) #5
Srirama
On 2015/07/14 18:25:10, ddorwin wrote: > LGTM % removal of includes added in https://codereview.chromium.org/1133033003/. > ...
5 years, 5 months ago (2015-07-14 18:36:59 UTC) #6
Srirama
jam@: Owner's review please. I will address ddorwin's comments before landing the patch tomorrow.
5 years, 5 months ago (2015-07-14 18:38:46 UTC) #8
jam
lgtm
5 years, 5 months ago (2015-07-14 20:18:43 UTC) #9
Srirama
https://codereview.chromium.org/1234573004/diff/1/components/html_viewer/frame.cc File components/html_viewer/frame.cc (right): https://codereview.chromium.org/1234573004/diff/1/components/html_viewer/frame.cc#newcode36 components/html_viewer/frame.cc:36: #include "third_party/WebKit/public/platform/WebMediaPlayerClient.h" On 2015/07/14 18:25:10, ddorwin wrote: > Remove ...
5 years, 5 months ago (2015-07-15 06:14:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234573004/20001
5 years, 5 months ago (2015-07-15 06:14:38 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-15 06:18:52 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 06:19:52 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9d1423af551de300783135062156069539dc57e0
Cr-Commit-Position: refs/heads/master@{#338825}

Powered by Google App Engine
This is Rietveld 408576698