Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: public/platform/modules/notifications/WebNotificationData.h

Issue 1234553003: Supports the sound attribute to the Notification object Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: [WIP] Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/modules/notifications/WebNotificationData.h
diff --git a/public/platform/modules/notifications/WebNotificationData.h b/public/platform/modules/notifications/WebNotificationData.h
index 75b2575bc93323c4a40354845645166bae443c01..c419de1fb0d4c22ae3c734872e0ba05089e50a15 100644
--- a/public/platform/modules/notifications/WebNotificationData.h
+++ b/public/platform/modules/notifications/WebNotificationData.h
@@ -24,6 +24,7 @@ struct WebNotificationData {
{
}
+ // FIXME: Remove this constructor when Chromium has switched to the new one.
WebNotificationData(const WebString& title, Direction direction, const WebString& lang, const WebString& body, const WebString& tag, const WebURL& icon, const WebVector<int>& vibrate, bool silent, const WebVector<char>& data)
: title(title)
, direction(direction)
@@ -37,12 +38,27 @@ struct WebNotificationData {
{
}
+ WebNotificationData(const WebString& title, Direction direction, const WebString& lang, const WebString& body, const WebString& tag, const WebURL& icon, const WebURL& sound, const WebVector<int>& vibrate, bool silent, const WebVector<char>& data)
+ : title(title)
+ , direction(direction)
+ , lang(lang)
+ , body(body)
+ , tag(tag)
+ , icon(icon)
+ , sound(sound)
+ , vibrate(vibrate)
+ , silent(silent)
+ , data(data)
+ {
+ }
+
WebString title;
Direction direction;
WebString lang;
WebString body;
WebString tag;
WebURL icon;
+ WebURL sound;
WebVector<int> vibrate;
bool silent;
WebVector<char> data;
« no previous file with comments | « Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698