Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: content/common/user_agent.cc

Issue 1234543003: Report Android Build.MODEL in SystemProfileProto hardware_class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address jdduke's comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/user_agent.cc
diff --git a/content/common/user_agent.cc b/content/common/user_agent.cc
index f3e113da7c180ada1d540dc309e7c17e76f6727f..467ad97f4d79400058b260abd2b54a12c4d266b1 100644
--- a/content/common/user_agent.cc
+++ b/content/common/user_agent.cc
@@ -23,16 +23,6 @@
namespace content {
-namespace {
-
-#if defined(OS_ANDROID)
-std::string GetAndroidDeviceName() {
- return base::SysInfo::GetDeviceName();
-}
-#endif
-
-} // namespace
-
std::string GetWebKitVersion() {
return base::StringPrintf("%d.%d (%s)",
WEBKIT_VERSION_MAJOR,
@@ -107,7 +97,7 @@ std::string BuildOSCpuInfo() {
// Send information about the device.
bool semicolon_inserted = false;
std::string android_build_codename = base::SysInfo::GetAndroidBuildCodename();
- std::string android_device_name = GetAndroidDeviceName();
+ std::string android_device_name = base::SysInfo::HardwareModelName();
if ("REL" == android_build_codename && android_device_name.size() > 0) {
android_info_str += "; " + android_device_name;
semicolon_inserted = true;
« base/sys_info_android.cc ('K') | « chrome/browser/ui/android/android_about_app_info.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698