Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2754)

Unified Diff: base/sys_info.h

Issue 1234543003: Report Android Build.MODEL in SystemProfileProto hardware_class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address jdduke's comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/sys_info.cc » ('j') | base/sys_info_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/sys_info.h
diff --git a/base/sys_info.h b/base/sys_info.h
index 654d6945a34ba26250356f5b21caa5c8a16f6112..8b20db8a6768aedf729944f8b5fd2d62b2878a1b 100644
--- a/base/sys_info.h
+++ b/base/sys_info.h
@@ -52,9 +52,10 @@ class BASE_EXPORT SysInfo {
static int64 Uptime();
// Returns a descriptive string for the current machine model or an empty
- // string if machime model is unknown or an error occured.
- // e.g. MacPro1,1 on Mac.
- // Only implemented on OS X, will return an empty string on other platforms.
+ // string if the machine model is unknown or an error occured.
+ // e.g. "MacPro1,1" on Mac, or "Nexus 5" on Android.
+ // Only implemented on OS X and Android, will return an empty string on other
rkaplow 2015/07/14 19:43:19 this actually is set for ChromeOS as well. Can you
tdresser 2015/07/14 20:57:31 Done.
+ // platforms.
static std::string HardwareModelName();
// Returns the name of the host operating system.
@@ -129,9 +130,6 @@ class BASE_EXPORT SysInfo {
// Returns the Android build ID.
static std::string GetAndroidBuildID();
- // Returns the device's name.
- static std::string GetDeviceName();
-
static int DalvikHeapSizeMB();
static int DalvikHeapGrowthLimitMB();
#endif // defined(OS_ANDROID)
« no previous file with comments | « no previous file | base/sys_info.cc » ('j') | base/sys_info_android.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698