Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Unified Diff: base/sys_info_android.cc

Issue 1234543003: Report Android Build.MODEL in SystemProfileProto hardware_class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove GetDeviceName(). Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/sys_info_android.cc
diff --git a/base/sys_info_android.cc b/base/sys_info_android.cc
index 245097ffdc092626923e8bcb2f1bbf99e08e51d6..389e90c3f29149be77e2f5a6e52fc3610974f6ad 100644
--- a/base/sys_info_android.cc
+++ b/base/sys_info_android.cc
@@ -171,7 +171,7 @@ std::string SysInfo::GetAndroidBuildID() {
return std::string(os_build_id_str);
}
-std::string SysInfo::GetDeviceName() {
+std::string SysInfo::HardwareModelName() {
char device_model_str[PROP_VALUE_MAX];
jdduke (slow) 2015/07/14 18:46:48 Nit: Should we move this up above OperatingSystemN
tdresser 2015/07/14 19:02:27 Done.
__system_property_get("ro.product.model", device_model_str);
return std::string(device_model_str);

Powered by Google App Engine
This is Rietveld 408576698