Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 123453002: Show "Chrome" on the tabstrip for chrome signin page (Closed)

Created:
6 years, 11 months ago by guohui
Modified:
6 years, 11 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Show "Chrome" on the tabstrip for chrome signin page BUG=330683 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243643

Patch Set 1 : #

Total comments: 2

Patch Set 2 : string moved to chromium_string.grd #

Total comments: 2

Patch Set 3 : nits fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M chrome/app/chromium_strings.grd View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/inline_login/inline_login.html View 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_ui.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
guohui
Hey, could you please take a look at my CL? Thanks, Hui
6 years, 11 months ago (2014-01-02 20:55:57 UTC) #1
xiyuan
https://codereview.chromium.org/123453002/diff/20001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/123453002/diff/20001/chrome/app/generated_resources.grd#newcode10748 chrome/app/generated_resources.grd:10748: + Chrome Think we should use IDS_SHORT_PRODUCT_NAME. Or moving ...
6 years, 11 months ago (2014-01-06 19:38:52 UTC) #2
guohui
https://codereview.chromium.org/123453002/diff/20001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/123453002/diff/20001/chrome/app/generated_resources.grd#newcode10748 chrome/app/generated_resources.grd:10748: + Chrome On 2014/01/06 19:38:52, xiyuan wrote: > Think ...
6 years, 11 months ago (2014-01-07 21:35:02 UTC) #3
xiyuan
lgtm https://codereview.chromium.org/123453002/diff/160001/chrome/browser/ui/webui/signin/inline_login_ui.cc File chrome/browser/ui/webui/signin/inline_login_ui.cc (right): https://codereview.chromium.org/123453002/diff/160001/chrome/browser/ui/webui/signin/inline_login_ui.cc#newcode13 chrome/browser/ui/webui/signin/inline_login_ui.cc:13: #include "grit/generated_resources.h" nit: this is probably not needed.
6 years, 11 months ago (2014-01-07 21:51:55 UTC) #4
guohui
https://codereview.chromium.org/123453002/diff/160001/chrome/browser/ui/webui/signin/inline_login_ui.cc File chrome/browser/ui/webui/signin/inline_login_ui.cc (right): https://codereview.chromium.org/123453002/diff/160001/chrome/browser/ui/webui/signin/inline_login_ui.cc#newcode13 chrome/browser/ui/webui/signin/inline_login_ui.cc:13: #include "grit/generated_resources.h" On 2014/01/07 21:51:56, xiyuan wrote: > nit: ...
6 years, 11 months ago (2014-01-07 22:10:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/123453002/220001
6 years, 11 months ago (2014-01-07 22:12:17 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242903
6 years, 11 months ago (2014-01-08 04:05:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/123453002/220001
6 years, 11 months ago (2014-01-08 19:33:49 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 21:06:06 UTC) #9
Message was sent while issue was closed. 
Change committed as 243643

Powered by Google App Engine
This is Rietveld 408576698