Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 1234513003: Correctly handle the case when TimerTask is destroyed with being run. (Closed)

Created:
5 years, 5 months ago by ulan
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Correctly handle the case when TimerTask is destroyed with being run. This is follow-up for a5616e. BUG=chromium:508584 LOG=NO Committed: https://crrev.com/530e36d7b306fa5a7afb637e605f40cca35256fc Cr-Commit-Position: refs/heads/master@{#29594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M src/heap/memory-reducer.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/heap/memory-reducer.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL
5 years, 5 months ago (2015-07-13 09:34:56 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-13 09:45:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234513003/1
5 years, 5 months ago (2015-07-13 09:47:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-13 10:18:22 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 10:18:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/530e36d7b306fa5a7afb637e605f40cca35256fc
Cr-Commit-Position: refs/heads/master@{#29594}

Powered by Google App Engine
This is Rietveld 408576698