Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 1234503004: Revert of Remove rt flags that are not necessary (Closed)

Created:
5 years, 5 months ago by bsalomon
Modified:
5 years, 5 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Remove rt flags that are not necessary (patchset #1 id:1 of https://codereview.chromium.org/1226123012/) Reason for revert: breaks tests, e.g. https://build.chromium.org/p/client.skia.android/builders/Test-Android-GCC-Nexus9-GPU-TegraK1-Arm64-Release/builds/752/steps/dm/logs/stdio Original issue's description: > Remove rt flags that are not necessary > > Committed: https://skia.googlesource.com/skia/+/b6b0a6ef179f4143c94ba7e0e1be6e7ce4b0a23a TBR=joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/bea0150d83d5b840a236cc2c8444371b121c99fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/FloatingPointTextureTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/SurfaceTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
Created Revert of Remove rt flags that are not necessary
5 years, 5 months ago (2015-07-16 16:59:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234503004/1
5 years, 5 months ago (2015-07-16 17:00:20 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 17:00:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bea0150d83d5b840a236cc2c8444371b121c99fe

Powered by Google App Engine
This is Rietveld 408576698