Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 1234493002: Tweak GYP to also link with XCode 7. (Closed)

Created:
5 years, 5 months ago by mtklein_C
Modified:
5 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Tweak GYP to also link with XCode 7. Using the XCode 7 beta, the file in the GYP doesn't exist, instead we get /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/lib/libz.tbd which is a text file describing libz and pointing to /usr/lib/libz.1.dylib. There's a weird easy fix, which is that GYP looks for things in libraries like 'libz.dylib' and pattern match translates that to '-lz' on the command line. (Infuriatingly, a literal '-lz' is interpreted as a file path...) BUG=skia: Committed: https://skia.googlesource.com/skia/+/24d8249638706acc28b32959aa7b093cf356f38a

Patch Set 1 #

Patch Set 2 : Maybe this works? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gyp/zlib.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234493002/1
5 years, 5 months ago (2015-07-10 02:37:03 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/4367)
5 years, 5 months ago (2015-07-10 02:38:39 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234493002/20001
5 years, 5 months ago (2015-07-10 12:34:05 UTC) #6
mtklein_C
5 years, 5 months ago (2015-07-10 12:40:10 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-10 12:41:08 UTC) #10
mtklein
lgtm
5 years, 5 months ago (2015-07-13 14:48:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234493002/20001
5 years, 5 months ago (2015-07-13 14:48:17 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 15:13:06 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/24d8249638706acc28b32959aa7b093cf356f38a

Powered by Google App Engine
This is Rietveld 408576698