Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: media/base/android/media_player_bridge.h

Issue 1234483003: Prevent seeking when Android MediaPlayer reports that it's not possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments from DaleCurtis. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | media/base/android/media_player_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/media_player_bridge.h
diff --git a/media/base/android/media_player_bridge.h b/media/base/android/media_player_bridge.h
index 291aa97959dbfa7dd4136cd6db5d7422bbbdeea7..b63a49a6d6e61553b59a3e78e6ed3696cbb50c86 100644
--- a/media/base/android/media_player_bridge.h
+++ b/media/base/android/media_player_bridge.h
@@ -99,13 +99,15 @@ class MEDIA_EXPORT MediaPlayerBridge : public MediaPlayerAndroid {
virtual base::android::ScopedJavaLocalRef<jobject> GetAllowedOperations();
private:
+ friend class MediaPlayerBridgeTest;
+
// Set the data source for the media player.
void SetDataSource(const std::string& url);
// Functions that implements media player control.
void StartInternal();
void PauseInternal();
- void SeekInternal(base::TimeDelta time);
+ bool SeekInternal(base::TimeDelta current_time, base::TimeDelta time);
qinmin 2015/07/17 04:16:28 the current_time can always be retrieved from getC
keitchen 2015/07/20 20:24:23 GetCurrentTime() issues a JNI call to the media pl
// Called when |time_update_timer_| fires.
void OnTimeUpdateTimerFired();
« no previous file with comments | « AUTHORS ('k') | media/base/android/media_player_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698