media/base/android/media_player_bridge.h - Issue 1234483003: Prevent seeking when Android MediaPlayer reports that it's not possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_player_bridge.h

Issue 1234483003: Prevent seeking when Android MediaPlayer reports that it's not possible. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/android/media_player_bridge.h

diff --git a/media/base/android/media_player_bridge.h b/media/base/android/media_player_bridge.h

index 291aa97959dbfa7dd4136cd6db5d7422bbbdeea7..ab18271c13fc00eb4e33b2e3ae92f9fc674e9d3a 100644

--- a/media/base/android/media_player_bridge.h

+++ b/media/base/android/media_player_bridge.h

@@ -99,13 +99,15 @@ class MEDIA_EXPORT MediaPlayerBridge : public MediaPlayerAndroid {

virtual base::android::ScopedJavaLocalRef<jobject> GetAllowedOperations();

private:

+ friend class MediaPlayerBridgeTest;

// Set the data source for the media player.

void SetDataSource(const std::string& url);

// Functions that implements media player control.

void StartInternal();

void PauseInternal();

- void SeekInternal(base::TimeDelta time);

+ bool SeekInternal(const base::TimeDelta& current_time, base::TimeDelta time);

DaleCurtis 2015/07/16 00:29:28 Pass TimeDelta by value since it's an int64 (see t

keitchen 2015/07/17 00:00:06 Done.

// Called when |time_update_timer_| fires.

void OnTimeUpdateTimerFired();

« no previous file with comments | « AUTHORS ('k') | media/base/android/media_player_bridge.cc » ('j') | media/base/android/media_player_bridge_unittest.cc » ('J')