Issue 1234463006: make strokefill gm portable

Issue 1234463006: make strokefill gm portable (Closed)

Created:
5 years, 5 months ago by caryclark

Modified:
5 years, 5 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

make strokefill gm portable Convert the Mac-specific font text statically into paths so that they draw the same on all platforms. Add drawing portable text using the fake bold paint setting so that the code path is tested everywhere and but draws the same thing. R=reed@google.com Committed: https://skia.googlesource.com/skia/+/e148ac5262eeb3e9a3726f1e5335cbfe33c879d9

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+243 lines, -8 lines)			Patch
	M	gm/strokefill.cpp	View	1	3 chunks	+243 lines, -8 lines	0 comments	Download

Total messages: 10 (3 generated)

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234463006/1

5 years, 5 months ago (2015-07-15 19:49:56 UTC) #3

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

5 years, 5 months ago (2015-07-15 19:57:12 UTC) #5

reed1

lgtm if we could reduce the shear number of verbs that would make this more ...

5 years, 5 months ago (2015-07-15 20:38:48 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234463006/20001

5 years, 5 months ago (2015-07-15 20:43:42 UTC) #9

commit-bot: I haz the power

5 years, 5 months ago (2015-07-15 21:03:15 UTC) #10

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e148ac5262eeb3e9a3726f1e5335cbfe33c879d9