Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: Source/core/layout/LayoutTableCell.cpp

Issue 1234463005: Don't invalidate cell when collapsed border changes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: NeedsRebaseline Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/core/layout/LayoutTableSection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutTableCell.cpp
diff --git a/Source/core/layout/LayoutTableCell.cpp b/Source/core/layout/LayoutTableCell.cpp
index b74d0ced08f00dfefe75f2c9fba87d7b1acb7724..296f32745de18e8ac7e8a83a55ad847d749a1ac4 100644
--- a/Source/core/layout/LayoutTableCell.cpp
+++ b/Source/core/layout/LayoutTableCell.cpp
@@ -954,15 +954,10 @@ void LayoutTableCell::collectBorderValues(LayoutTable::CollapsedBorderValues& bo
CollapsedBorderValue beforeBorder = computeCollapsedBeforeBorder();
CollapsedBorderValue afterBorder = computeCollapsedAfterBorder();
LayoutTableSection* section = this->section();
- bool changed = section->setCachedCollapsedBorder(this, CBSStart, startBorder);
- changed |= section->setCachedCollapsedBorder(this, CBSEnd, endBorder);
- changed |= section->setCachedCollapsedBorder(this, CBSBefore, beforeBorder);
- changed |= section->setCachedCollapsedBorder(this, CBSAfter, afterBorder);
-
- // In slimming paint mode, we need to invalidate all cells with collapsed border changed.
- // FIXME: Need a way to invalidate/repaint the borders only. crbug.com/451090#c5.
- if (changed && RuntimeEnabledFeatures::slimmingPaintEnabled())
- invalidateDisplayItemClient(*this);
+ section->setCachedCollapsedBorder(this, CBSStart, startBorder);
+ section->setCachedCollapsedBorder(this, CBSEnd, endBorder);
+ section->setCachedCollapsedBorder(this, CBSBefore, beforeBorder);
+ section->setCachedCollapsedBorder(this, CBSAfter, afterBorder);
addBorderStyle(borderValues, startBorder);
addBorderStyle(borderValues, endBorder);
« no previous file with comments | « LayoutTests/TestExpectations ('k') | Source/core/layout/LayoutTableSection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698