Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1234463004: cc: Initialize wait_for_beginframe_interval in tests. (Closed)

Created:
5 years, 5 months ago by brianderson
Modified:
5 years, 5 months ago
Reviewers:
danakj, Jimmy Jo
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Initialize wait_for_beginframe_interval in tests. Only setting disable_display_vsync isn't sufficient and results in timeouts on Android perf bots. BUG=510430 TBR=danakj CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/9bf7d5657eab1f1f57e9527fd2af9a8786e5d979 Cr-Commit-Position: refs/heads/master@{#338894}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M cc/trees/layer_tree_host_perftest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brianderson
ptal. This potentially fixes perf bot timeouts.
5 years, 5 months ago (2015-07-15 17:24:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234463004/1
5 years, 5 months ago (2015-07-15 17:51:18 UTC) #4
danakj
LGTM
5 years, 5 months ago (2015-07-15 17:53:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-15 19:53:02 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 19:53:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bf7d5657eab1f1f57e9527fd2af9a8786e5d979
Cr-Commit-Position: refs/heads/master@{#338894}

Powered by Google App Engine
This is Rietveld 408576698