Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1234443004: [turbofan] Add an InterpreterDispatch linkage type. (Closed)

Created:
5 years, 5 months ago by rmcilroy
Modified:
5 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, oth, picksi1
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add an InterpreterDispatch linkage type. BUG=v8:4280 LOG=N Committed: https://crrev.com/a0129a25ba2f4d00138887cb2008d5b76e2b0068 Cr-Commit-Position: refs/heads/master@{#29591}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -4 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm/linkage-arm.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/linkage-arm64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ia32/linkage-ia32.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/linkage.h View 3 chunks +12 lines, -3 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/linkage-impl.h View 1 chunk +21 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips/linkage-mips.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/linkage-mips64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/linkage-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rmcilroy
No rush, but please take a look, thanks. Let me know if there is anywhere ...
5 years, 5 months ago (2015-07-10 16:15:07 UTC) #2
Benedikt Meurer
LGTM.
5 years, 5 months ago (2015-07-13 04:41:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234443004/1
5 years, 5 months ago (2015-07-13 07:58:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-13 08:27:44 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 08:27:54 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a0129a25ba2f4d00138887cb2008d5b76e2b0068
Cr-Commit-Position: refs/heads/master@{#29591}

Powered by Google App Engine
This is Rietveld 408576698