Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1234443003: Prepare for using ninja for win64. (Closed)

Created:
5 years, 5 months ago by Michael Achenbach
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Prepare for using ninja for win64. BUG=chromium:508921 LOG=n Committed: https://crrev.com/0a3b77397b59f3146a6eb4780de3326c4248eb33 Cr-Commit-Position: refs/heads/master@{#29605}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review #

Patch Set 3 : Patch to work after https://codereview.chromium.org/1231423003/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M build/standalone.gypi View 1 1 chunk +13 lines, -0 lines 0 comments Download
M tools/run-tests.py View 1 2 3 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
Michael Achenbach
PTAL - this will be accompanied with an infra-side fix on the ninja bot (if ...
5 years, 5 months ago (2015-07-10 20:01:42 UTC) #2
Jakob Kummerow
LGTM if it works. https://codereview.chromium.org/1234443003/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/1234443003/diff/1/build/standalone.gypi#newcode361 build/standalone.gypi:361: 'conditions': [ nit: indentation (one ...
5 years, 5 months ago (2015-07-13 08:33:50 UTC) #3
Michael Achenbach
On 2015/07/13 08:33:50, Jakob wrote: > LGTM if it works. > > https://codereview.chromium.org/1234443003/diff/1/build/standalone.gypi > File ...
5 years, 5 months ago (2015-07-13 10:42:11 UTC) #4
Michael Achenbach
PTAL at patch 3. This makes things work after https://codereview.chromium.org/1231423003/ lands.
5 years, 5 months ago (2015-07-13 11:09:55 UTC) #5
Jakob Kummerow
Patch set 3 LGTM.
5 years, 5 months ago (2015-07-13 11:12:04 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-13 11:12:54 UTC) #7
Michael Achenbach
Looks like this works: http://build.chromium.org/p/tryserver.v8/builders/v8_win64_ninja_rel/builds/2
5 years, 5 months ago (2015-07-13 11:35:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234443003/40001
5 years, 5 months ago (2015-07-13 11:35:34 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-13 12:39:18 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 12:39:35 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0a3b77397b59f3146a6eb4780de3326c4248eb33
Cr-Commit-Position: refs/heads/master@{#29605}

Powered by Google App Engine
This is Rietveld 408576698