src/trusted/validator_ragel/validator.h - Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator_ragel/validator.h

Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other) (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Renaming Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/trusted/validator_ragel/dfa_validate_common.c ('K') | « src/trusted/validator_ragel/instruction_definitions/xmm_instructions.def ('k') | src/trusted/validator_ragel/validator_x86_32.rl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator_ragel/validator.h

diff --git a/src/trusted/validator_ragel/validator.h b/src/trusted/validator_ragel/validator.h

index 633195e3641150820f5167810867339ad3ef7c4c..1cae6ed8cb66915b7cec1e2fbd8faff727da1829 100644

--- a/src/trusted/validator_ragel/validator.h

+++ b/src/trusted/validator_ragel/validator.h

@@ -64,7 +64,7 @@ enum validation_callback_info {

/* Was restricted_register from previous instruction used in this one? */

RESTRICTED_REGISTER_USED = 0x00002000,

/* Mask to select all validation errors. */

- VALIDATION_ERRORS_MASK = 0x01ffc000,

+ VALIDATION_ERRORS_MASK = 0x05ffc000,

/* Unrecognized instruction: fatal error, processing stops here. */

UNRECOGNIZED_INSTRUCTION = 0x00004000,

/* Direct jump to unaligned address outside of given region. */

@@ -95,6 +95,8 @@ enum validation_callback_info {

SP_MODIFIED = 0x01000000,

/* Bad call alignment: "call" must end at the end of the bundle. */

BAD_CALL_ALIGNMENT = 0x02000000,

+ /* The instruction should be either forbidden or rewritten. */

+ FORBID_OR_REWRITE_INSTRUCTION = 0x04000000,

Petr Hosek 2015/07/20 23:58:57 To be consistent with the annotation, I'd call thi

ruiq 2015/07/21 02:52:25 Done.

/* Instruction is modifiable by nacl_dyncode_modify. */

MODIFIABLE_INSTRUCTION = 0x08000000,

/* Special instruction. Uses different, non-standard validation rules. */