src/trusted/validator_ragel/def_format.py - Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator_ragel/def_format.py

Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other) (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Renaming Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/trusted/validator/validation_pnacl_mode_test.cc ('K') | « src/trusted/validator_mips/ncvalidate.cc ('k') | src/trusted/validator_ragel/dfa_validate_32.c » ('j') | src/trusted/validator_ragel/dfa_validate_common.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator_ragel/def_format.py

diff --git a/src/trusted/validator_ragel/def_format.py b/src/trusted/validator_ragel/def_format.py

index 1075974012a12d7aeb6f386a26afca99c64edc06..bf24dcdfab43c0a908983df053d25ef56231233e 100644

--- a/src/trusted/validator_ragel/def_format.py

+++ b/src/trusted/validator_ragel/def_format.py

@@ -291,6 +291,7 @@ SUPPORTED_ATTRIBUTES = [

'nacl-ia32-forbidden',

'nacl-amd64-forbidden',

'nacl-forbidden',

+ 'nacl-forbid-or-rewrite',

ruiq 2015/07/19 19:20:33 I feel this name is more explicit than something l

Petr Hosek 2015/07/20 23:58:57 I'd prefer `nacl-unsupported`; `nacl-forbid-or-rew

ruiq 2015/07/21 02:52:24 Done.

'nacl-amd64-zero-extends',

'nacl-amd64-modifiable',

'disabled_untested',