Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: src/trusted/validator_ragel/dll_utils.c

Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other) (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: Fixing nits Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator_ragel/dll_utils.c
diff --git a/src/trusted/validator_ragel/dll_utils.c b/src/trusted/validator_ragel/dll_utils.c
index 13bde3e6b5c032ffe1f1c76683a9df5086266ed7..8a05a9930a70237e3fe66aeb5c21a1f4abb48d68 100644
--- a/src/trusted/validator_ragel/dll_utils.c
+++ b/src/trusted/validator_ragel/dll_utils.c
@@ -45,6 +45,11 @@ Bool ExtractRestrictedRegisterCallback(
void *data) {
struct CallbackData *callback_data = data;
+ /* UNSUPPORTED_INSTRUCTION indicates validation failure only for pnacl-mode.
+ * Since by default we are in non-pnacl-mode, the flag is simply cleared.
+ */
+ info &= ~UNSUPPORTED_INSTRUCTION;
+
if (end <= callback_data->actual_end && (info & VALIDATION_ERRORS_MASK)) {
callback_data->valid = FALSE;
}

Powered by Google App Engine
This is Rietveld 408576698