Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: src/trusted/validator_mips/ncvalidate.cc

Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other) (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: Fixing nits Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator_mips/ncvalidate.cc
diff --git a/src/trusted/validator_mips/ncvalidate.cc b/src/trusted/validator_mips/ncvalidate.cc
index ea3a67e2f4fd94da99038814cd4a52844bda66a6..ff9a38e9b9e95dc692425b9758611137e0c9b134 100644
--- a/src/trusted/validator_mips/ncvalidate.cc
+++ b/src/trusted/validator_mips/ncvalidate.cc
@@ -10,6 +10,7 @@
#include "native_client/src/include/nacl_string.h"
#include "native_client/src/include/portability.h"
+#include "native_client/src/shared/platform/nacl_check.h"
#include "native_client/src/shared/utils/types.h"
#include "native_client/src/trusted/service_runtime/arch/mips/sel_ldr_mips.h"
#include "native_client/src/trusted/cpu_features/arch/mips/cpu_mips.h"
@@ -117,10 +118,12 @@ static NaClValidationStatus ApplyValidatorMips(
uint8_t *data,
size_t size,
int stubout_mode,
+ uint32_t flags,
int readonly_text,
const NaClCPUFeatures *cpu_features,
const struct NaClValidationMetadata *metadata,
struct NaClValidationCache *cache) {
+ CHECK((flags & MIPS_VALIDATION_FLAGS_MASK) == 0);
void *query = NULL;
const NaClCPUFeaturesMips *features =
(const NaClCPUFeaturesMips *) cpu_features;

Powered by Google App Engine
This is Rietveld 408576698