src/trusted/validator_ragel/dfa_validate_common.h - Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator_ragel/dfa_validate_common.h

Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other) (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Fixing nits Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/trusted/validator_arm/ncvalidate.cc ('K') | « src/trusted/validator_ragel/dfa_validate_64.c ('k') | src/trusted/validator_ragel/dfa_validate_common.c » ('j') | src/trusted/validator_ragel/dfa_validate_common.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator_ragel/dfa_validate_common.h

diff --git a/src/trusted/validator_ragel/dfa_validate_common.h b/src/trusted/validator_ragel/dfa_validate_common.h

index 4835f2006ea7b4945f440b3be0a3b35ec5cc63a9..c033907629560c4d81e1b81204e8fdd246036fea 100644

--- a/src/trusted/validator_ragel/dfa_validate_common.h

+++ b/src/trusted/validator_ragel/dfa_validate_common.h

@@ -31,10 +31,16 @@

Bool NaClDfaProcessValidationError(const uint8_t *begin, const uint8_t *end,

uint32_t info, void *callback_data);

-Bool NaClDfaStubOutCPUUnsupportedInstruction(const uint8_t *begin,

- const uint8_t *end,

- uint32_t info,

- void *callback_data);

+struct StubOutCallbackData {

+ uint32_t flags;

+ int did_rewrite;

+};

+Bool NaClDfaStubOutUnsupportedInstruction(const uint8_t *begin,

+ const uint8_t *end,

+ uint32_t info,

+ void *callback_data);

struct CodeCopyCallbackData {

NaClCopyInstructionFunc copy_func;

/* Difference between addresses: dest - src. */