src/trusted/validator/ncvalidate.h - Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator/ncvalidate.h

Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other) (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Add (ARCH)_VALIDATION_FLAGS_MASK Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « src/trusted/validator/driver/ncval.cc ('k') | src/trusted/validator/validation_cache_test.cc » ('j') | src/trusted/validator/validation_disable_nontemporals_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator/ncvalidate.h

diff --git a/src/trusted/validator/ncvalidate.h b/src/trusted/validator/ncvalidate.h

index a06f53e9114d0b92e0923773afa16c212bff8b73..e104b67630a558a400d4550955b9de4ff6a5049e 100644

--- a/src/trusted/validator/ncvalidate.h

+++ b/src/trusted/validator/ncvalidate.h

@@ -20,6 +20,14 @@ EXTERN_C_BEGIN

struct NaClValidationCache;

struct NaClValidationMetadata;

+/* Defines possible validation flags. */

+typedef enum NaClValidationFlags {

+ DISABLE_NONTEMPORALS = 0x1,

+ X86_VALIDATION_FLAGS_MASK = 0x1,

+ ARM_VALIDATION_FLAGS_MASK = 0x0,

+ MIPS_VALIDATION_FLAGS_MASK = 0x0

+} NaClValidationFlags;

/* Defines possible validation status values. */

typedef enum NaClValidationStatus {

/* The call to the validator succeeded. */

@@ -63,6 +71,7 @@ typedef NaClValidationStatus (*NaClValidateFunc)(

uint8_t *data,

size_t size,

int stubout_mode,

+ uint32_t flags,

int readonly_text,

const NaClCPUFeatures *cpu_features,

const struct NaClValidationMetadata *metadata,